Implement cancellation notifications #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Mar 31, 2025
stephentoub
force-pushed
the
implementcancellation
branch
2 times, most recently
from
af43905 to
5507c56
Compare
src/ModelContextProtocol/Protocol/Messages/ProgressNotification.cs
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
implementcancellation
branch
from
5507c56 to
fdda2b5
Compare
PederHP
reviewed
Mar 31, 2025
There was a problem hiding this comment.
For later: It should probably documented that tool methods can use CancellationToken in the signature to hook into the cancellation notifications. Even if that is built-in functionality for AIFunction, it would be valuable to know that the CancellationToken is a combined one.
stephentoub
force-pushed
the
implementcancellation
branch
from
fdda2b5 to
b87bb40
Compare
PederHP
reviewed
Mar 31, 2025
PederHP
approved these changes
Mar 31, 2025
eiriktsarpalis
approved these changes
Mar 31, 2025
This was referenced Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Ignore the first commit; it's just #145, which this builds on top of.)
Closes #112